SatSale

commit 6e26321cd432d30d984e3f2cff40dac4f2157b85
parent 510a70d21915622559069e59d9e48f3aab740af7
Author: root <root@guest.guest>
Date:   Tue, 12 Jan 2021 06:17:16 +0000

fix merge with remote copy

Diffstat:
M
README.md
 | 
13
+++++++++----
M
invoice/payment_invoice.py
 | 
2
+-

2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/README.md b/README.md
@@ -8,15 +8,16 @@ Currently, BTCPyment only provides donation buttons, but we plan to soon extend 
  BTCPyment makes donation buttons simple; using Python and Javascript to talk to your own Bitcoin node, with an easy iframe embed install. BTCPyment uses RPC to generate new addresses from your Bitcoin node, and monitors the payment status with your own copy of the blockchain. Soon, we hope to support lightning payments as well as function as a payment processor for a variety of web shops (woocommerce, shopify).
 
 # Features
-* Lightweight, Python and Javascript talk to your own Bitcoin node via websockets and SSH.
-* Direct peer-to-peer payments without any middleman. No KYC, and greater privacy than donation systems with reused Bitcoin addresses.
+* Talk to your own Bitcoin node via RPC and SSH. Bitcoin core, or any other node software that supports RPC calls.
+* Lightweight - Python and Javascript websockets.
+* Direct peer-to-peer payments without any middleman. No KYC, and greater privacy than donation systems wher Bitcoin addresses are reused multiple times.
 * Natively supports all bitcoind node features (e.g. segwit) through RPC.
 * QR codes, user chooses the minimum payment confirmations and payment expiry duration.
 * Highly extendable, just take a look at the code! Optional code execution upon payment.
 * No shitcoin bloat. Bitcoin only.
 
 # Installation (short!)
-BTCPyment requires you to have a server host on, and a connection to a Bitcoin node. If you don't have one, you should [install one](https://bitcoincore.org/en/download/).
+You require a server to host an instance of BTCPyment on, and a connection to a Bitcoin node. If you don't have a Bitcoin node, you should [install one](https://bitcoincore.org/en/download/).
 ### Install
 Clone and install dependencies
 ```
@@ -50,8 +51,12 @@ Now embed the donation button into your website:
 ```html
 <iframe src="http://YOUR_SERVER_IP:8000/" style="margin: 0 auto;display:block;height:320px;border:none;overflow:hidden;" scrolling="no"></iframe>
 ```
+Changing `YOUR_SERVER_IP` to the IP address of the machine you're running BTCPyment through. Optionally, you can redirect a domain to that IP and use that instead.
 
-## Using HTTPS
+## Security
+For maximum security, we recommend hosting on a machine where your node only has access to a **watch-only** wallet.
+
+## Using HTTPS & Domains
 Embedded iframes are easy if your site only uses HTTP. But if your site uses HTTPS, then you can likely see your donation button at `http://YOUR_SERVER_IP:8000/` but not in the embeded iframe. See [HTTPS instructions](docs/HTTPS.md).
 
 # Developers
diff --git a/invoice/payment_invoice.py b/invoice/payment_invoice.py
@@ -21,7 +21,7 @@ class invoice:
 
 
     def create_qr(self):
-        qr_str = "bitcoin:{}?amount={}&label=".format(self.address, self.value, self.label)
+        qr_str = "BITCOIN:{}?amount={}&label={}".format(self.address.upper(), self.value, self.label)
         img = qrcode.make(qr_str)
         img.save('static/qr_codes/{}.png'.format(self.uuid))
         return